feat!: allow dynamic infura networks#9432
Open
mikesposito wants to merge 5 commits into
Open
Conversation
mikesposito
force-pushed
the
me/WPN-1554-allow-dynamic-infura-networks
branch
from
21722a6 to
ce206bd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
mikesposito
temporarily deployed
to
default-branch
GitHub Actions
Inactive
mikesposito
commented
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently,
NetworkControllermanages two types of network config:InfuraandCustom. TheInfuratype is dedicated to configurations with RPC endpoints with an Infura URL that uses a template string for the project ID, whileCustomconfigurations are generic network configurations that can be also added by users.In order to add a network configuration of Infura type to NetworkController, the network must first be added to
@metamask/controller-utilsto satisfyNetworkControllervalidations, or else it won’t be recognized as a known network, and the operation will fail with an error. This currently blocks us from leveraging mm-config-registry (Dynamic registry) from being used to add Infura network configurations remotely.This PR relaxes
NetworkControllervalidations to accept Infura configurations that are not included in@metamask/controller-utils, nor in any other bundled known list.References
Checklist
Note
High Risk
Breaking changes to core network client resolution, add/update validation, and
eth_chainIdscaffolding affect all RPC traffic; consumers must adopt new types and error strings.Overview
NetworkController no longer requires Infura-backed networks to appear in
@metamask/controller-utils. Infura configs can use arbitrary subdomain strings and chain IDs without cross-checking the URL against a bundled network list.Breaking types:
BuiltInNetworkClientIdandInfuraNetworkClientConfiguration.networkare now plainstringinstead ofInfuraNetworkType. Consumers that narrowed on known Infura names should useNetworkClientTypeon the client configuration instead.Validation removed: custom RPC endpoints may reuse IDs that look like built-in Infura names, and add/update no longer rejects mismatches between
chainIdand the Infura URL’s implied network.Runtime behavior:
getNetworkClientByIdresolves Infura then custom clients withoutisInfuraNetworkTypegating and throws a single message (No network client was found with ID "…"). Infura provider middleware answerseth_chainIdfrom the configuration’schainIdrather thanChainId[network]. Downstream tests (e.g. assets-controllers) were updated for the new error text.Reviewed by Cursor Bugbot for commit 58ad075. Bugbot is set up for automated code reviews on this repo. Configure here.